Skip to content

refactor(eslint): use cordova-eslint#194

Merged
timbru31 merged 1 commit intomasterfrom
feat/eslint
Jul 2, 2020
Merged

refactor(eslint): use cordova-eslint#194
timbru31 merged 1 commit intomasterfrom
feat/eslint

Conversation

@timbru31
Copy link
Copy Markdown
Member

@timbru31 timbru31 commented Jul 1, 2020

Ref apache/cordova#142
Ref apache/cordova#4
Closes #141
Closes #143

Platforms affected

Motivation and Context

Description

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

Copy link
Copy Markdown
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

The only comment is that I noticed the package-lock.json task is also completed under this PR. Others had told me in the past to separate this change in its own PR.

@timbru31
Copy link
Copy Markdown
Member Author

timbru31 commented Jul 2, 2020

Will do a separate PR (for the others, too)

@timbru31 timbru31 merged commit 1aaa960 into master Jul 2, 2020
@timbru31 timbru31 deleted the feat/eslint branch July 2, 2020 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert to eslint

2 participants