Replace VM_ARGS with ARGS_FILE which is borrowed from couchdb startup #2738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t /etc/vm.args; also parses name from config.
wohali
approved these changes
Apr 22, 2020
wohali
added a commit
that referenced
this pull request
Apr 22, 2020
…t /etc/vm.args; also parses name from config. (#2738) Co-authored-by: sklassen <none> Co-authored-by: Joan Touzet <[email protected]>
wohali
added a commit
that referenced
this pull request
Apr 22, 2020
…t /etc/vm.args; also parses name from config. (#2738) Co-authored-by: sklassen <none> Co-authored-by: Joan Touzet <[email protected]>
This was referenced Apr 22, 2020
wohali
added a commit
that referenced
this pull request
Apr 22, 2020
…t /etc/vm.args; also parses name from config. (#2738) (#2809) Co-authored-by: Joan Touzet <[email protected]> Co-authored-by: Simon Klassen <[email protected]>
wohali
added a commit
that referenced
this pull request
Apr 22, 2020
…t /etc/vm.args; also parses name from config. (#2738) (#2810) Co-authored-by: Joan Touzet <[email protected]> Co-authored-by: Simon Klassen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the environment VM_ARGS with ARGS_FILE, which is the same name and set the same manner as the couchdb script;
The new script also parses name from the same file.
Overview
The current remsh script required you specify the name and cookie if they differ from the system default. The new script synchronizes the setting of ARGS_FILE with that environment in the couchdb startup script. This now also, like the couchdb startup script, respects any COUCHDB_ARGS_FILE override.
Testing recommendations
I changed the COUCHDB_ARGS_FILE environment variable and reran rmsh it and saw that it picked up non-default name and cookie.
Related Issues or Pull Requests
This answers (the linux) part of #2176
Checklist
rel/overlay/etc/default.ini