bypass partition query limit for mango #3105
Conversation
When partition_query_limit is set for couch_mrview, it limits how many docs can be scanned when executing partitioned queries. But this limits mango's doc scans internally. This leads to documents not being scanned to fulfill a query. This fixes: #2795
tonysun83
force-pushed
the
fix-partition-query-limit
branch
from
c2670f9 to
7dbd0ad
Compare
|
@wohali CI seems to be failing with |
|
Hey @tonysun83 , Looking at the commit history, If you run I realize this, strictly speaking, is an unrelated change to fixing mango, but your help is greatly appreciated :) and a single PR is faster than 2. |
|
thx @wohali , it looks good! |
davisp
left a comment
davisp
left a comment
There was a problem hiding this comment.
All good except for the random hunk mixed in.
| "^\[httpd\]$", | ||
| "[httpd]\nenable = true", | ||
| contents, | ||
| flags=re.MULTILINE, |
There was a problem hiding this comment.
What's this change for? Looks like styling which we shouldn't mix.
There was a problem hiding this comment.
Line's too long, required change to make python black happy. It is unrelated but needs to go in because otherwise tests fail. Don't give him grief on this one.
|
@tonysun83 Would you backport this (mango) fix to 3.x too? |
3 participants
Overview
When partition_query_limit is set for couch_mrview, it limits how many
docs can be scanned when executing partitioned queries. But this limits
mango's doc scans internally. This leads to documents not being scanned
to fulfill a query. This fixes:
#2795
Testing recommendations
Unit Test added.
Related Issues or Pull Requests
Checklist
rel/overlay/etc/default.ini