Skip to content

Conversation

@jiangphcn
Copy link
Contributor

Overview

In some situation where design document for search index created by customer is not valid, the _search_cleanup endpoint will stop to clean up. This will leave some search index orphan. The change is to allow to continue to clean up search index even if there is invalid design document for search.

Testing recommendations

make elixir tests=src/dreyfus/test/elixir/test/search_test.exs


SearchTest
  * test clean up search index with invalid design document (55.1ms)

ReshardHelpers

PartitionHelpers


Finished in 0.07 seconds
1 test, 0 failures

Related Issues or Pull Requests

Checklist

In some situation where design document for search index created by
customer is not valid, the _search_cleanup endpoint will stop to clean
up. This will leave some search index orphan. The change is to allow
to continue to clean up search index even if there is invalid design
document for search.
@jiangphcn jiangphcn marked this pull request as draft September 1, 2020 05:24
@wohali
Copy link
Member

wohali commented Sep 1, 2020

When this is ready, please backport to 3.x.

This will be the last change before I cut CouchDB 3.1.1, if it makes it in today or tomorrow 😉

@jiangphcn jiangphcn marked this pull request as ready for review September 1, 2020 08:02
@jiangphcn jiangphcn merged commit 27eefab into master Sep 1, 2020
@jiangphcn
Copy link
Contributor Author

thanks @garrensmith for review and thanks @wohali for sharing the chance to put this into 3.x. I just merged change #3119 to 3.x.

@jiangphcn jiangphcn deleted the dreyfus-cleanup-with-invalid-ddoc branch September 1, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants