fix memleak in couch_peruser, patch by @rnewson #3851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnewson
reviewed
Nov 26, 2021
rnewson
approved these changes
Nov 26, 2021
nickva
requested changes
Nov 26, 2021
Contributor
nickva
left a comment
nickva
left a comment
There was a problem hiding this comment.
To prevent memory leaks, a better pattern might be to not unlink and respawn mem3_cluster processes, but to keep the existing (single) one around. We are already linked to it and we don't set the trap_exit flag. So if it crashes it should restart the couch_peruser gen_server as well.
| -spec init_state() -> #state{}. | ||
| init_state() -> | ||
| reset_state(#state{mem3_cluster_pid = Pid} = State) when is_pid(Pid) -> | ||
| unlink(Pid), |
Contributor
There was a problem hiding this comment.
Here we just unlink the process, but the process would still be alive and we'd be accumulating them and each one would still be sending stable|unstable events. The memleak is not from the links themselves but from the number of processes spawned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.