-
Notifications
You must be signed in to change notification settings - Fork 643
Added support for SQLite triggers #2037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
if !dialect_of!(self is SQLiteDialect ) { | ||
self.expect_keyword_is(Keyword::FOR)?; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if !dialect_of!(self is SQLiteDialect ) { | |
self.expect_keyword_is(Keyword::FOR)?; | |
} | |
self.expect_keyword_is(Keyword::FOR)?; |
Can we skip the dialect guard here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems this comment is unresolved? ideally we want to skip dialect_of checks where possible
Regarding commit c893bda, it should be noted that the |
Co-authored-by: Ifeanyi Ubah <[email protected]>
Co-authored-by: Ifeanyi Ubah <[email protected]>
This PR:
CREATE TRIGGER
for SQLite dialect, which was early blocked by a dialect guardTEMPORARY
keyword, which may be desirable if we want to raise errors in other dialect ifTEMP
triggers are provided.FOR EACH ROW
in triggers, which is optional in SQLiteCREATE TRIGGER
cases in SQLite.DROP TRIGGER
for SQLite dialect, which was early blocked by a dialect guardDROP TRIGGER
case in SQLite.Closes issue #2023