Skip to content

Fix docs.rs build for datafusion-proto (hopefully) #10254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
comphead merged 1 commit into from
Apr 27, 2024
Merged

Fix docs.rs build for datafusion-proto (hopefully) #10254

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix docs.rs build for datafusion-proto
  • Loading branch information
@alamb
alamb committed Apr 26, 2024
commit 059cfcb1a91be8337d668fe8446dd76448e2bcdf
1 change: 0 additions & 1 deletion datafusion/proto/src/generated/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@

#[allow(clippy::all)]
#[rustfmt::skip]
#[cfg(not(docsrs))]
Copy link
Contributor Author

@alamb alamb Apr 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was added in #3580 but now that the code is vendored (doesn't require running protoc at compile time) I think it should work

However, I don't really understand why it stopped working in the first place 🤔

pub mod datafusion {
include!("prost.rs");

Expand Down