Skip to content

Update string-view branch to arrow-rs main #10966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 6 commits into from
Jun 18, 2024
Merged

Update string-view branch to arrow-rs main #10966

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
50aec29
Pin to arrow main
alamb Jun 17, 2024
d9057fb
Fix clippy with latest arrow
alamb Jun 17, 2024
57808ca
Uncomment test that needs new arrow-rs to work
alamb Jun 17, 2024
982c0e9
Update datafusion-cli Cargo.lock
alamb Jun 17, 2024
3de2c2c
Update Cargo.lock
alamb Jun 17, 2024
3cb74b9
tapelo
alamb Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Uncomment test that needs new arrow-rs to work
  • Loading branch information
@alamb
alamb committed Jun 17, 2024
commit 57808ca9116f53cf2906d755bd2bcc0b81d36dd9
4 changes: 0 additions & 4 deletions datafusion/common/src/scalar/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5446,16 +5446,12 @@ mod tests {
DataType::Dictionary(Box::new(DataType::Int32), Box::new(DataType::Utf8)),
);

// needs https://github.com/apache/arrow-rs/issues/5893
/*
Copy link
Contributor Author

@alamb alamb Jun 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test now works!

check_scalar_cast(ScalarValue::Utf8(None), DataType::Utf8View);
check_scalar_cast(ScalarValue::from("foo"), DataType::Utf8View);
check_scalar_cast(
ScalarValue::from("larger than 12 bytes string"),
DataType::Utf8View,
);

*/
}

// mimics how casting work on scalar values by `casting` `scalar` to `desired_type`
Expand Down