Skip to content

Implement support for LargeString and LargeBinary for StringView and BinaryView #11034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 3 commits into from
Jun 21, 2024
Merged

Implement support for LargeString and LargeBinary for StringView and BinaryView #11034

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
76fa9e8
implement large binary
XiangpengHao Jun 20, 2024
d1c7019
add tests for large string
XiangpengHao Jun 20, 2024
39356a6
better comments for string coercion
XiangpengHao Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
better comments for string coercion
  • Loading branch information
@XiangpengHao
XiangpengHao committed Jun 20, 2024
commit 39356a6292941e7752a10cf297f4629a1698ca68
12 changes: 6 additions & 6 deletions datafusion/expr/src/type_coercion/binary.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -930,13 +930,13 @@ fn string_concat_internal_coercion(
fn string_coercion(lhs_type: &DataType, rhs_type: &DataType) -> Option<DataType> {
use arrow::datatypes::DataType::*;
match (lhs_type, rhs_type) {
// If Utf8View is in any side, we coerce to Utf8View.
(Utf8View, Utf8View | Utf8 | LargeUtf8) | (Utf8 | LargeUtf8, Utf8View) => {
Some(Utf8View)
}
// Then, if LargeUtf8 is in any side, we coerce to LargeUtf8.
(LargeUtf8, Utf8 | LargeUtf8) | (Utf8, LargeUtf8) => Some(LargeUtf8),
(Utf8, Utf8) => Some(Utf8),
(LargeUtf8, Utf8) | (Utf8, LargeUtf8) | (LargeUtf8, LargeUtf8) => Some(LargeUtf8),
(Utf8View, Utf8View)
| (Utf8View, Utf8)
| (Utf8, Utf8View)
| (LargeUtf8, Utf8View)
| (Utf8View, LargeUtf8) => Some(Utf8View),
_ => None,
}
}
Expand Down