Skip to content

perf: Optimize IsNotNullExpr #11586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 6 commits into from
Jul 24, 2024
Merged

perf: Optimize IsNotNullExpr #11586

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8bb26ae
add criterion benchmarks for IsNullExpr and IsNotNullExpr
andygrove Jul 21, 2024
bf7cf97
Improve IsNotNull performance by avoiding calling is_null then not an…
andygrove Jul 21, 2024
70d254f
fast path if input array is all nulls or no nulls
andygrove Jul 21, 2024
34b0b7f
revert experimental change
andygrove Jul 21, 2024
75caa45
remove unused import
andygrove Jul 21, 2024
2b7613d
simplify PR
andygrove Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revert experimental change
  • Loading branch information
@andygrove
andygrove committed Jul 21, 2024
commit 34b0b7f0638cfd5acb329b07b272315dbd4549c5
15 changes: 2 additions & 13 deletions datafusion/physical-expr/src/expressions/is_not_null.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,20 +73,9 @@ impl PhysicalExpr for IsNotNullExpr {
fn evaluate(&self, batch: &RecordBatch) -> Result<ColumnarValue> {
let arg = self.arg.evaluate(batch)?;
match arg {
ColumnarValue::Array(array) if array.as_any().is::<UnionArray>() => {
Ok(ColumnarValue::Array(Arc::new(
super::is_null::compute_is_not_null(array)?,
)))
}
ColumnarValue::Array(array) => {
if array.null_count() == 0 {
Ok(ColumnarValue::Scalar(ScalarValue::Boolean(Some(true))))
} else if array.null_count() == array.len() {
Ok(ColumnarValue::Scalar(ScalarValue::Boolean(Some(false))))
} else {
let is_not_null = super::is_null::compute_is_not_null(array)?;
Ok(ColumnarValue::Array(Arc::new(is_not_null)))
}
let is_not_null = super::is_null::compute_is_not_null(array)?;
Ok(ColumnarValue::Array(Arc::new(is_not_null)))
}
ColumnarValue::Scalar(scalar) => Ok(ColumnarValue::Scalar(
ScalarValue::Boolean(Some(!scalar.is_null())),
Expand Down
11 changes: 1 addition & 10 deletions datafusion/physical-expr/src/expressions/is_null.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,17 +77,8 @@ impl PhysicalExpr for IsNullExpr {
fn evaluate(&self, batch: &RecordBatch) -> Result<ColumnarValue> {
let arg = self.arg.evaluate(batch)?;
match arg {
ColumnarValue::Array(array) if array.as_any().is::<UnionArray>() => {
Ok(ColumnarValue::Array(Arc::new(compute_is_null(array)?)))
}
ColumnarValue::Array(array) => {
if array.null_count() == 0 {
Ok(ColumnarValue::Scalar(ScalarValue::Boolean(Some(false))))
} else if array.null_count() == array.len() {
Ok(ColumnarValue::Scalar(ScalarValue::Boolean(Some(true))))
} else {
Ok(ColumnarValue::Array(Arc::new(compute_is_null(array)?)))
}
Ok(ColumnarValue::Array(Arc::new(compute_is_null(array)?)))
}
ColumnarValue::Scalar(scalar) => Ok(ColumnarValue::Scalar(
ScalarValue::Boolean(Some(scalar.is_null())),
Expand Down