support ANY() op
#11849
support ANY() op
#11849
Conversation
github-actions
bot
added
sql
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @samuelcolvin -- this looks quite good to me
The only thing I think it needs is a .slt level test
Can you please add one?
Here are the instructions: https://github.com/apache/datafusion/tree/main/datafusion/sqllogictest
Ideally you should be able to extend one of the existing test files in https://github.com/apache/datafusion/tree/main/datafusion/sqllogictest/test_files
Maybe somewhere in
datafusion/datafusion/sqllogictest/test_files/array.slt
Lines 4973 to 4979 in bddb641
samuelcolvin
left a comment
samuelcolvin
left a comment
There was a problem hiding this comment.
I think this is ready.
| fn plan_make_map(&self, args: Vec<Expr>) -> Result<PlannerResult<Vec<Expr>>> { | ||
| if args.len() % 2 != 0 { | ||
| return exec_err!("make_map requires an even number of arguments"); | ||
| return plan_err!("make_map requires an even number of arguments"); |
There was a problem hiding this comment.
drive-by change, since this is a "plan" method I assume a "plan error" is more appropriate?
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @samuelcolvin -- looks great to me
3 participants
Which issue does this PR close?
Half of #6602 - the overwhelmingly common half.
Rationale for this change
Trying to support as much postgreSQL syntax as possible,
ANY()queries are fairly common.What changes are included in this PR?
ANY()operator, as in'needle'=ANY(haystack)array_hasto be less confusingANY()Are these changes tested?
Yes, I can add more if you want.
Are there any user-facing changes?
Common queries with
ANY()should now work