Skip to content

fix: calling with_column twice and using a window function for the 2nd call returns an error #12428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Michael-J-Ward wants to merge 5 commits into from
Closed

fix: calling with_column twice and using a window function for the 2nd call returns an error #12428

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4f186ef
add test for with_column bug
Michael-J-Ward Sep 11, 2024
66a17e5
convert DataFrame::with_column into API sugar
Michael-J-Ward Sep 11, 2024
7bebf93
update expected logical_plan for with_column_join_same_columns
Michael-J-Ward Sep 11, 2024
979594f
update with_column_self_join test
Michael-J-Ward Sep 11, 2024
96974f4
update with_column to what I think is the full semantic equivalent us…
Michael-J-Ward Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update expected logical_plan for with_column_join_same_columns 
The sugared version uses a wildcard to express the previous columns
  • Loading branch information
@Michael-J-Ward
Michael-J-Ward committed Sep 11, 2024
commit 7bebf934347575eba207dc07ffa29b0e7aa45b82
2 changes: 1 addition & 1 deletion datafusion/core/src/dataframe/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3013,7 +3013,7 @@ mod tests {

assert_eq!(
"\
Projection: t1.c1, t2.c1, Boolean(true) AS new_column\
Projection: *, Boolean(true) AS new_column\
\n Limit: skip=0, fetch=1\
\n Sort: t1.c1 ASC NULLS FIRST\
\n Inner Join: t1.c1 = t2.c1\
Expand Down