Skip to content

Check window functions by str for with_column #12431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
comphead merged 5 commits into from
Sep 11, 2024
Merged

Check window functions by str for with_column #12431

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ffbda4c
Check for window functions already in schema by str match instead of …
timsaucer Sep 11, 2024
910985d
cargo fmt
timsaucer Sep 11, 2024
51f9f63
Update with single liner to make code easier to read
timsaucer Sep 11, 2024
3cf08ea
Update test documentation
timsaucer Sep 11, 2024
62e7e6a
Cargo fmt
timsaucer Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update test documentation
  • Loading branch information
@timsaucer
timsaucer committed Sep 11, 2024
commit 3cf08eaa8af7843d23bcbfdb52f8bd98aa868309
6 changes: 3 additions & 3 deletions datafusion/core/src/dataframe/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2974,7 +2974,8 @@ mod tests {
Ok(())
}

// Test issue: https://github.com/apache/datafusion/issues/11982
// Test issues: https://github.com/apache/datafusion/issues/11982
// and https://github.com/apache/datafusion/issues/12425
// Window function was creating unwanted projection when using with_column() method.
#[tokio::test]
async fn test_window_function_with_column() -> Result<()> {
Expand All @@ -2986,8 +2987,7 @@ mod tests {
// This first `with_column` results in a column without a `qualifier`
let df_impl = df_impl.with_column("s", col("c2") + col("c3"))?;

// This second `with_column` then assigns `"r"` alias to the above column and the window function
// Should create an additional column with alias 'r' that has window func results
// This second `with_column` should only alias `func` as `"r"`
let df = df_impl.with_column("r", func)?.limit(0, Some(2))?;

df.clone().show().await?;
Expand Down