Add Dictionary String (UTF8) type to String sqllogictests #12621
Conversation
|
I tried adding another test file for |
submit apache/arrow-rs#6456 for it. |
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
This is great -- thank you @goldmedal
| DataType::Timestamp(_, _) => DFColumnType::Timestamp, | ||
| DataType::Dictionary(key_type, value_type) => { | ||
| if key_type.is_integer() { | ||
| // mapping dictionary string types to Text |
| pub fn cell_to_string( | ||
| col: &ArrayRef, | ||
| row: usize, | ||
| data_type: &DataType, |
There was a problem hiding this comment.
Minor nit is that since this data type comes from col it seems like we could keep the signature of this function the same and call let data_type = col.data_type() in the function
There was a problem hiding this comment.
oops... my bad. It's my other experimental change. I forgot to roll back it. I'll recover it. Thanks for mentioning it.
| # | ||
| # common test for string-like functions and operators | ||
| # | ||
| include ./string_query.slt.part |
|
🚀 |
* mapping DictionaryString to text * disable and move out the fail case for dictionary string * fix the schema for dictionary string * rollback the unnecessary change * cargo fmt
2 participants
Which issue does this PR close?
Part of #12415 .
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Add the test for dictionary Utf8
Are there any user-facing changes?
no