Avoid send empty batches for Hash partitioning. #1459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dandandan
reviewed
Dec 17, 2021
Ted-Jiang
force-pushed
the
issue_1405
branch
from
e98e0fc to
a8863ce
Compare
Dandandan
approved these changes
Dec 17, 2021
| for (num_output_partition, partition_indices) in | ||
| indices.into_iter().enumerate() | ||
| { | ||
| if partition_indices.is_empty() { |
Member
Author
|
fix UT check in #1462 |
Contributor
Could you rebase to fix the linting errors? |
Ted-Jiang
force-pushed
the
issue_1405
branch
from
a8863ce to
413d3bf
Compare
Member
Author
|
it seems no CI error, i rebase -i upstream/master
it seems no CI error, i rebase -i upstream/master and force push it |
Dandandan
approved these changes
Dec 19, 2021
Contributor
|
Thank you @Ted-Jiang ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
#1405
Closes #1405 .