Pass local address host so we do not get mismatch between IPv4 and IP… #1466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…v6 addresses
Which issue does this PR close?
Fixes #1020
Closes #.
Closes #1020
Rationale for this change
Currently when using Ballista standalone, the standalone executor does not send its local IP when registering metadata with the scheduler. The scheduler will default to the IPv4 caller address even though the executor is listening on the IPv6 loopback address (on some platforms). This will cause clients to fail to fetch partitions when they try and call the flight service on the IPv4 socket instead of the IPv6 socket.
What changes are included in this PR?
Standalone executor should explicitly return it's local IP address when registering metadata
Are there any user-facing changes?
I don't think so.
I don't think so.