Skip to content

Make SessionContext::register_parquet obey collect_statistics config #16080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 10 commits into from
May 21, 2025
Merged

Make SessionContext::register_parquet obey collect_statistics config #16080

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
843bce3
fix
adriangb May 18, 2025
d0ad650
add a test
adriangb May 19, 2025
710e1e5
fmt
adriangb May 19, 2025
98588de
add to upgrade guide
adriangb May 19, 2025
8b7b047
fix tests
adriangb May 19, 2025
d9a7eee
fix test
adriangb May 19, 2025
4beea49
fix test
adriangb May 19, 2025
5e12a73
fix ci
adriangb May 19, 2025
c06c41b
Fix example in upgrade guide (#29)
alamb May 21, 2025
57cc550
Merge branch 'main' into collect-stats-off
adriangb May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fmt
  • Loading branch information
@adriangb
adriangb committed May 19, 2025
commit 710e1e57e9f2bc5317c02ccc2e22c474daaccf00
15 changes: 3 additions & 12 deletions datafusion/core/src/execution/context/parquet.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,32 +153,23 @@ mod tests {
config.options_mut().explain.physical_plan_only = true;
config.options_mut().explain.show_statistics = true;
let content = explain_query_all_with_config(config).await?;
assert_contains!(
content,
"statistics=[Rows=Absent,"
);
assert_contains!(content, "statistics=[Rows=Absent,");

// Explicitly set to false
let mut config = SessionConfig::new();
config.options_mut().explain.physical_plan_only = true;
config.options_mut().explain.show_statistics = true;
config.options_mut().execution.collect_statistics = false;
let content = explain_query_all_with_config(config).await?;
assert_contains!(
content,
"statistics=[Rows=Absent,"
);
assert_contains!(content, "statistics=[Rows=Absent,");

// Explicitly set to true
let mut config = SessionConfig::new();
config.options_mut().explain.physical_plan_only = true;
config.options_mut().explain.show_statistics = true;
config.options_mut().execution.collect_statistics = true;
let content = explain_query_all_with_config(config).await?;
assert_contains!(
content,
"statistics=[Rows=Exact(10),"
);
assert_contains!(content, "statistics=[Rows=Exact(10),");

Ok(())
}
Expand Down