Skip to content

[FEATURE] Add concurrency safety for application-level metadata state / 为应用级 metadata 全局状态补充并发安全 #3353

Description

@Alanxtl

上下文请参考 #3188 (comment)

Background

After the #2534 metadata refactor, application-level metadata is maintained through shared state such as local MetadataInfo, metadata report instances, and MetadataService. This issue only focuses on concurrency safety in the application-level metadata path.

Related code:

  • metadata/metadata.go
  • metadata/info/metadata_info.go
  • metadata/report_instance.go
  • registry/servicediscovery/service_instances_changed_listener_impl.go

Current Problems

Multiple core states are maps without clear synchronization protection.

Specific problems:

  • registryMetadataInfo is a global map.
  • MetadataInfo.Services, exportedServiceURLs, and subscribedServiceURLs are maps.
  • Metadata report instances is a global map.
  • Register, unregister, subscribe, unsubscribe, service instance change, and metadata service query may happen concurrently.

This may cause data races, stale reads, or concurrent map write panics.

Suggestions

  • Add clear synchronization rules for metadata global state.
  • Define the concurrent read/write model for MetadataInfo.
  • Protect register, unregister, subscribe, unsubscribe, and query paths.
  • Cover key metadata and service discovery paths with go test -race.
  • Avoid directly exposing mutable internal maps or slices.

背景

#2534 metadata 重构之后,应用级 metadata 通过本地 MetadataInfo、metadata report 实例和 MetadataService 等共享状态维护。本 issue 只关注应用级 metadata 链路中的并发安全。

相关代码:

  • metadata/metadata.go
  • metadata/info/metadata_info.go
  • metadata/report_instance.go
  • registry/servicediscovery/service_instances_changed_listener_impl.go

当前问题

当前多处核心状态是 map,但缺少清晰的同步保护。

具体问题:

  • registryMetadataInfo 是全局 map。
  • MetadataInfo.Services、exportedServiceURLs、subscribedServiceURLs 是 map。
  • metadata report instances 是全局 map。
  • 注册、注销、订阅、取消订阅、实例变更、metadata service 查询可能并发发生。

这可能导致 data race、stale read 或并发 map 写 panic。

建议

  • 为 metadata 全局状态增加明确的同步规则。
  • 定义 MetadataInfo 的并发读写模型。
  • 保护注册、注销、订阅、取消订阅和查询链路。
  • 使用 go test -race 覆盖 metadata 和 service discovery 关键路径。
  • 避免直接暴露可变内部 map 或 slice。

Activity

  1. added theissue type on May 30, 2026
  2. changed the title [-][metadata] 为应用级 metadata 全局状态补充并发安全[/-] [+][FEATURE] Add concurrency safety for application-level metadata state / 为应用级 metadata 全局状态补充并发安全[/+] on May 30, 2026
  3. jieguo-coder commented on May 30, 2026

    @jieguo-coder
    Contributor

    Hello, may I try to do this?

  4. Alanxtl commented on Jun 25, 2026

    @Alanxtl
    MemberAuthor

    close via #3367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions