Repository navigation
feat(metadata): Clarify metadata report selection for multi-registry and multi-instance scenarios #3369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AlexStocks
merged 19 commits into
apache:develop
from
XnLemon:clarify-metadata-report-selection
Jun 10, 2026
Merged
feat(metadata): Clarify metadata report selection for multi-registry and multi-instance scenarios #3369
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
4a0ec86
fix(metadata): make GetMetadataReport() deterministic in multi-regist…
XnLemon 3e9ebc6
fix(metadata): Remove() fans out to all reports, consistent with Map()
XnLemon 7ff288d
fix(metadata): thread registryId through GetMetadataFromMetadataRepor…
XnLemon 4e83c0c
fix(metadata): scope revision calculation to per-registry services, t…
XnLemon 7ebc49f
fix(metadata): GetMetadataReportByRegistry returns nil for unknown re…
XnLemon 8008879
fix(metadata): ServiceNameMapping.Remove collects all errors instead …
XnLemon 38ab94b
test: expand coverage for per-registry metadata report selection
XnLemon 9ec6abc
chore: translate Chinese comments to English, remove UTF-8 BOM
XnLemon 2388f30
style(metadata): fix import formatting
XnLemon 663d4cf
fix(registry): upgrade missing-registryId log from Warn to Error with…
XnLemon e18c4b3
fix(registry): scope metaCache key to (registryId, revision) to preve…
XnLemon bd33338
docs(registry): restore TODO for multi-instance metadata service URL …
XnLemon 5276882
Revert "docs(registry): restore TODO for multi-instance metadata serv…
xianingawa-wq a117cbd
style(metadata): fix import formatting
xianingawa-wq 36719da
fix(debug) : fix review problems
xianingawa-wq a18c95c
style(metadata): fix format issue && revert some changes
xianingawa-wq 81160b7
fix(metadata): update tests and comment to match default fallback in …
xianingawa-wq dbedc14
fix: address review comments on clarify-metadata-report-selection
XnLemon 91b9136
fix: fix test isolation and cache key format after review changes
XnLemon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(metadata): ServiceNameMapping.Remove collects all errors instead …
…of returning only the last one The previous implementation used a lastErr variable that was overwritten on each iteration. If the first report failed and the second succeeded, the error was silently discarded and the caller saw no error despite a partial failure — leaving a stale mapping in the first registry. Fix: collect all errors with errors.Join so the caller receives the full failure picture. The loop continues past individual failures (best-effort fan-out) so a transient error in one registry does not prevent removal from the others. Add a comment explaining the intentional behavioural difference from Map(), which is fail-fast: Map stops at the first report failure, while Remove continues and collects all errors so every reachable registry gets the removal attempt.
- Loading branch information
commit 8008879a94a14e99f5a5dd0cd27167063a6d04e2
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.