Skip to content

fix(metadata, protocol, proxy): preserve request context across RPC paths - #3579

Merged
Alanxtl merged 14 commits into
apache:developfrom
XnLemon:fix/issue-3557-context-propagation
Aug 20, 2026
Merged

Alanxtl merged 14 commits into
apache:developfrom
XnLemon:fix/issue-3557-context-propagation

fix(context): address PR review cancellation feedback

2b2da28
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Jul 31, 2026 in 17s

Annotations

Check warning on line 50 in protocol/invocation/rpcinvocation.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'context.Context' field and pass context as a parameter to methods that need it.

See more on https://sonarcloud.io/project/issues?id=apache_dubbo-go&issues=AZ-yUvuioGPlgbDGtsVF&open=AZ-yUvuioGPlgbDGtsVF&pullRequest=3579

Check warning on line 63 in registry/servicediscovery/service_instances_changed_listener_impl.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'context.Context' field and pass context as a parameter to methods that need it.

See more on https://sonarcloud.io/project/issues?id=apache_dubbo-go&issues=AZ-2EP5gkb2krUTIC4IL&open=AZ-2EP5gkb2krUTIC4IL&pullRequest=3579

Check warning on line 63 in registry/servicediscovery/service_discovery_registry.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'context.Context' field and pass context as a parameter to methods that need it.

See more on https://sonarcloud.io/project/issues?id=apache_dubbo-go&issues=AZ-2EP5Gkb2krUTIC4IJ&open=AZ-2EP5Gkb2krUTIC4IJ&pullRequest=3579

Check warning on line 49 in protocol/rest/server/rest_server_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'context.Context' field and pass context as a parameter to methods that need it.

See more on https://sonarcloud.io/project/issues?id=apache_dubbo-go&issues=AZ-yUvpLoGPlgbDGtsVE&open=AZ-yUvpLoGPlgbDGtsVE&pullRequest=3579

Check warning on line 60 in remoting/exchange_client.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this interface to follow Go naming conventions for single-method interfaces.

See more on https://sonarcloud.io/project/issues?id=apache_dubbo-go&issues=AZ-2EP6Skb2krUTIC4IM&open=AZ-2EP6Skb2krUTIC4IM&pullRequest=3579

Check failure on line 82 in protocol/jsonrpc/server.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Defer the cancel function 'connectionCancel' after this context creation to prevent resource leaks.

See more on https://sonarcloud.io/project/issues?id=apache_dubbo-go&issues=AZ-2EPyJkb2krUTIC4IH&open=AZ-2EPyJkb2krUTIC4IH&pullRequest=3579

Check failure on line 293 in registry/servicediscovery/service_instances_changed_listener_impl.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 20 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=apache_dubbo-go&issues=AZ-2EP5gkb2krUTIC4IK&open=AZ-2EP5gkb2krUTIC4IK&pullRequest=3579

Check warning on line 487 in registry/servicediscovery/service_instances_changed_listener_impl_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'context.Context' field and pass context as a parameter to methods that need it.

See more on https://sonarcloud.io/project/issues?id=apache_dubbo-go&issues=AZ-2EP4okb2krUTIC4II&open=AZ-2EP4okb2krUTIC4II&pullRequest=3579

Check warning on line 415 in metadata/client_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'context.Context' field and pass context as a parameter to methods that need it.

See more on https://sonarcloud.io/project/issues?id=apache_dubbo-go&issues=AZ-yUvuzoGPlgbDGtsVG&open=AZ-yUvuzoGPlgbDGtsVG&pullRequest=3579