Skip to content

optimize: support http1 automatic keepalive setting #15019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oxsean merged 4 commits into from
Dec 26, 2024
Merged

optimize: support http1 automatic keepalive setting #15019

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c1d5b78
optimize: support http1 automatic keepalive setting
funky-eyes Dec 25, 2024
0e0216d
optimize: support http1 automatic keepalive setting
funky-eyes Dec 25, 2024
aae805e
optimize: support http1 automatic keepalive setting
funky-eyes Dec 26, 2024
a6dfb8e
optimize: support http1 automatic keepalive setting
funky-eyes Dec 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
optimize: support http1 automatic keepalive setting
  • Loading branch information
@funky-eyes
funky-eyes committed Dec 26, 2024
commit a6dfb8e60b1951833d7987218fc394868e7fb742
4 changes: 2 additions & 2 deletions ...ting-http12/src/main/java/org/apache/dubbo/remoting/http12/netty4/h1/NettyHttp1Codec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ private void doWriteHeader(ChannelHandlerContext ctx, HttpMetadata msg, ChannelP
headers.add(HttpHeaderNames.CONNECTION.getKey(), String.valueOf(HttpHeaderValues.CLOSE));
}
// process normal headers
ctx.write(new DefaultHttpResponse(HttpVersion.HTTP_1_1, status, headers.getHeaders()), promise);
ctx.writeAndFlush(new DefaultHttpResponse(HttpVersion.HTTP_1_1, status, headers.getHeaders()), promise);
}

private void doWriteMessage(ChannelHandlerContext ctx, HttpOutputMessage msg, ChannelPromise promise) {
Expand All @@ -107,7 +107,7 @@ private void doWriteMessage(ChannelHandlerContext ctx, HttpOutputMessage msg, Ch
OutputStream body = msg.getBody();
if (body instanceof ByteBufOutputStream) {
ByteBuf buffer = ((ByteBufOutputStream) body).buffer();
ctx.write(buffer, promise);
ctx.writeAndFlush(buffer, promise);
return;
}
throw new IllegalArgumentException("HttpOutputMessage body must be 'io.netty.buffer.ByteBufOutputStream'");
Expand Down