Skip to content

HADOOP-19449. Optimizing the null check logic in Lists and Sets methods. #7361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hfutatzhanghb wants to merge 1 commit into from
Closed

HADOOP-19449. Optimizing the null check logic in Lists and Sets methods. #7361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Lists.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,13 +247,13 @@ private static <T> Collection<T> cast(Iterable<T> iterable) {
*/
private static <T> boolean addAll(Collection<T> addTo,
Iterable<? extends T> elementsToAdd) {
if (addTo == null || elementsToAdd == null) {
throw new NullPointerException();
}
if (elementsToAdd instanceof Collection) {
Collection<? extends T> c = cast(elementsToAdd);
return addTo.addAll(c);
}
if (elementsToAdd == null) {
throw new NullPointerException();
}
return addAll(addTo, elementsToAdd.iterator());
}

Expand Down
6 changes: 3 additions & 3 deletions hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Sets.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,13 +160,13 @@ public static <E extends Comparable> TreeSet<E> newTreeSet(

private static <E extends Comparable> boolean addAll(TreeSet<E> addTo,
Iterable<? extends E> elementsToAdd) {
if (addTo == null || elementsToAdd == null) {
throw new NullPointerException();
}
if (elementsToAdd instanceof Collection) {
Collection<? extends E> c = cast(elementsToAdd);
return addTo.addAll(c);
}
if (elementsToAdd == null) {
throw new NullPointerException();
}
return addAll(addTo, elementsToAdd.iterator());
}

Expand Down