YARN-11244. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-yarn-client. #7438

slfan1989 · 2025-02-27T10:20:39Z

Description of PR

JIRA: YARN-11244. Upgrade JUnit from 4 to 5 in hadoop-yarn-client.

How was this patch tested?

Junit Test & mvn clean test.

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

hadoop-yetus · 2025-02-27T13:04:11Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 52s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 42 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	40m 26s		trunk passed
+1 💚	compile	0m 34s		trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	compile	0m 30s		trunk passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	checkstyle	0m 32s		trunk passed
+1 💚	mvnsite	0m 34s		trunk passed
+1 💚	javadoc	0m 34s		trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 29s		trunk passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	spotbugs	0m 55s		trunk passed
+1 💚	shadedclient	38m 16s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 23s		the patch passed
+1 💚	compile	0m 24s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javac	0m 24s		the patch passed
+1 💚	compile	0m 22s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	javac	0m 22s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 20s	/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt	hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client: The patch generated 7 new + 385 unchanged - 10 fixed = 392 total (was 395)
+1 💚	mvnsite	0m 24s		the patch passed
+1 💚	javadoc	0m 22s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 21s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	spotbugs	0m 54s		the patch passed
+1 💚	shadedclient	38m 44s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	33m 29s	/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt	hadoop-yarn-client in the patch passed.
+1 💚	asflicense	0m 39s		The patch does not generate ASF License warnings.
		162m 11s

Reason	Tests
Failed junit tests	hadoop.yarn.client.api.impl.TestYarnClientImpl
	hadoop.yarn.client.api.impl.TestYarnClient
	hadoop.yarn.client.api.impl.TestAMRMClient
	hadoop.yarn.client.TestRMFailover
	hadoop.yarn.client.TestGetGroups
	hadoop.yarn.client.util.TestYarnClientUtils

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7438/1/artifact/out/Dockerfile
GITHUB PR	#7438
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux b026ec6cc47f 5.15.0-131-generic #141-Ubuntu SMP Fri Jan 10 21:18:28 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `da75ec4`
Default Java	Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7438/1/testReport/
Max. process+thread count	607 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7438/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2025-02-27T18:33:18Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 50s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 42 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	43m 17s		trunk passed
+1 💚	compile	0m 33s		trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	compile	0m 31s		trunk passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	checkstyle	0m 32s		trunk passed
+1 💚	mvnsite	0m 34s		trunk passed
+1 💚	javadoc	0m 35s		trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 28s		trunk passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	spotbugs	0m 55s		trunk passed
+1 💚	shadedclient	38m 19s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 23s		the patch passed
+1 💚	compile	0m 24s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javac	0m 24s		the patch passed
+1 💚	compile	0m 22s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	javac	0m 22s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 20s	/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt	hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client: The patch generated 2 new + 386 unchanged - 9 fixed = 388 total (was 395)
+1 💚	mvnsite	0m 25s		the patch passed
+1 💚	javadoc	0m 23s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 21s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	spotbugs	0m 52s		the patch passed
+1 💚	shadedclient	38m 44s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	28m 55s		hadoop-yarn-client in the patch passed.
+1 💚	asflicense	0m 39s		The patch does not generate ASF License warnings.
		160m 16s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7438/2/artifact/out/Dockerfile
GITHUB PR	#7438
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux ea991f655fb3 5.15.0-131-generic #141-Ubuntu SMP Fri Jan 10 21:18:28 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `0019cb9`
Default Java	Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7438/2/testReport/
Max. process+thread count	559 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7438/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2025-03-01T03:11:44Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 49s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 42 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	41m 36s		trunk passed
+1 💚	compile	0m 33s		trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	compile	0m 31s		trunk passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	checkstyle	0m 32s		trunk passed
+1 💚	mvnsite	0m 34s		trunk passed
+1 💚	javadoc	0m 35s		trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 29s		trunk passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	spotbugs	0m 56s		trunk passed
+1 💚	shadedclient	38m 8s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 23s		the patch passed
+1 💚	compile	0m 25s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javac	0m 25s		the patch passed
+1 💚	compile	0m 22s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	javac	0m 22s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 20s		hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client: The patch generated 0 new + 386 unchanged - 9 fixed = 386 total (was 395)
+1 💚	mvnsite	0m 25s		the patch passed
+1 💚	javadoc	0m 22s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 20s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
+1 💚	spotbugs	0m 54s		the patch passed
+1 💚	shadedclient	38m 28s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	29m 5s		hadoop-yarn-client in the patch passed.
+1 💚	asflicense	0m 39s		The patch does not generate ASF License warnings.
		158m 31s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7438/3/artifact/out/Dockerfile
GITHUB PR	#7438
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 66d414b725f3 5.15.0-131-generic #141-Ubuntu SMP Fri Jan 10 21:18:28 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `71c7af2`
Default Java	Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06~~us1-0ubuntu1~~20.04-b06
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7438/3/testReport/
Max. process+thread count	558 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7438/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

slfan1989 · 2025-03-03T22:23:55Z

@cnauroth Could you please review this PR? Thank you very much!

cnauroth

+1. Thank you, @slfan1989 .

slfan1989 · 2025-03-04T01:06:47Z

@cnauroth Thank you very much for the review!

…pache#7438) [JDK17] Upgrade JUnit from 4 to 5 in hadoop-yarn-client. Co-authored-by: Chris Nauroth <[email protected]> Reviewed-by: Chris Nauroth <[email protected]> Signed-off-by: Shilun Fan <[email protected]>

YARN-11244. Upgrade JUnit from 4 to 5 in hadoop-yarn-client.

da75ec4

github-actions bot added YARN trunk labels Feb 27, 2025

slfan1989 changed the title ~~YARN-11244. Upgrade JUnit from 4 to 5 in hadoop-yarn-client.~~ YARN-11244. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-yarn-client. Feb 27, 2025

YARN-11244. Fix Junit Test & CheckStyle.

0019cb9

YARN-11244. Fix CheckStyle.

71c7af2

cnauroth approved these changes Mar 4, 2025

View reviewed changes

slfan1989 merged commit eda1236 into apache:trunk Mar 4, 2025
4 checks passed

slfan1989 mentioned this pull request Mar 9, 2025

[DISCUSS] [JDK17] Upgrade JUnit / JavaDoc from 4 to 5. #7337

Closed

75 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

YARN-11244. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-yarn-client. #7438

YARN-11244. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-yarn-client. #7438

Uh oh!

slfan1989 commented Feb 27, 2025 •

edited

Loading

Uh oh!

hadoop-yetus commented Feb 27, 2025

Uh oh!

hadoop-yetus commented Feb 27, 2025

Uh oh!

hadoop-yetus commented Mar 1, 2025

Uh oh!

slfan1989 commented Mar 3, 2025

Uh oh!

cnauroth left a comment

Uh oh!

Uh oh!

slfan1989 commented Mar 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

YARN-11244. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-yarn-client. #7438

YARN-11244. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-yarn-client. #7438

Uh oh!

Conversation

slfan1989 commented Feb 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

How was this patch tested?

For code changes:

Uh oh!

hadoop-yetus commented Feb 27, 2025

Uh oh!

hadoop-yetus commented Feb 27, 2025

Uh oh!

hadoop-yetus commented Mar 1, 2025

Uh oh!

slfan1989 commented Mar 3, 2025

Uh oh!

cnauroth left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

slfan1989 commented Mar 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

slfan1989 commented Feb 27, 2025 •

edited

Loading