Skip to content
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove commented out assertions
  • Loading branch information
Revathi Vijayaraghavan committed Jun 17, 2025
commit 1d5f246051a0c028f9cdfbeeaf148759fc4fcd69
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
String accessPoint = "testAp";
String[][] regionPartitionEndpoints = new String[][] {
{Region.EU_WEST_1.id(), "aws"},
{Region.US_GOV_EAST_1.id(), "aws-us-gov"},

Check failure on line 52 in hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/TestArnResource.java

View check run for this annotation

ASF Cloudbees Jenkins ci-hadoop / Apache Yetus

hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/TestArnResource.java#L52

blanks: end of line
{Region.CN_NORTH_1.id(), "aws-cn"},
};

Expand All @@ -58,10 +58,10 @@
String partition = testPair[1];

ArnResource resource = getArnResourceFrom(partition, "s3", region, MOCK_ACCOUNT, accessPoint);
// assertEquals(accessPoint, resource.getName(), "Access Point name does not match");
// assertEquals(MOCK_ACCOUNT, resource.getOwnerAccountId(), "Account Id does not match");
// assertEquals(region, resource.getRegion(), "Region does not match");
// assertEquals("s3", resource.getService(), "Service does not match");
assertEquals(accessPoint, resource.getName(), "Access Point name does not match");
assertEquals(MOCK_ACCOUNT, resource.getOwnerAccountId(), "Account Id does not match");
assertEquals(region, resource.getRegion(), "Region does not match");
assertEquals("s3", resource.getService(), "Service does not match");
}
}

Expand Down Expand Up @@ -108,7 +108,7 @@
"test");
describe("Using an invalid access point name format must throw when getting an endpoint.");

intercept(IllegalArgumentException.class, () ->

Check failure on line 111 in hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/TestArnResource.java

View check run for this annotation

ASF Cloudbees Jenkins ci-hadoop / Apache Yetus

hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/TestArnResource.java#L111

blanks: end of line
accessPoint.getEndpoint());
}

Expand Down
Loading