feat: reuse schemas & increment their IDS #495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twuebi
force-pushed
the
tp/reuse-schemas-increment-schema-ids
branch
from
9a16a1c to
bad1740
Compare
zeroshade
requested changes
Jul 25, 2025
Member
zeroshade
left a comment
zeroshade
left a comment
There was a problem hiding this comment.
In general, looks good. just some nitpicks
twuebi
force-pushed
the
tp/reuse-schemas-increment-schema-ids
branch
from
132f50c to
2e68dd9
Compare
twuebi
force-pushed
the
tp/reuse-schemas-increment-schema-ids
branch
from
2e68dd9 to
577cd2f
Compare
zeroshade
reviewed
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligns us a bit more with the Java & Rust implementations where functionally equivalent schemas don't get added a second time. It also aligns renumbering of schemas to be equivalent to java/rust.
Java source: https://github.com/apache/iceberg/blob/41c0b17a20c522e4df519bcc429f413e6a2855e5/core/src/main/java/org/apache/iceberg/TableMetadata.java#L117-L138
Rust source: https://github.com/apache/iceberg-rust/blob/c4c006939a3cb3bf684a0d10ba0e66cac484befe/crates/iceberg/src/spec/table_metadata_builder.rs#L1068