Skip to content

Support Snowflake-Managed Iceberg Tables via SnowflakeCatalog #1834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
srilman wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Support Snowflake-Managed Iceberg Tables via SnowflakeCatalog #1834

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e76947
Copied from PR and Bodo
srilman Mar 23, 2025
43ac041
Address comment
srilman Mar 23, 2025
15eb260
Address StaticTable comment
srilman Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Address StaticTable comment
  • Loading branch information
@srilman
srilman committed Mar 24, 2025
commit 15eb260c15ef9d277553f72917c2ecd817190caa
21 changes: 13 additions & 8 deletions pyiceberg/catalog/snowflake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@
)
from pyiceberg.partitioning import UNPARTITIONED_PARTITION_SPEC, PartitionSpec
from pyiceberg.schema import Schema
from pyiceberg.serializers import FromInputFile
from pyiceberg.table import (
CommitTableResponse,
StaticTable,
Table,
sorting,
)
Expand Down Expand Up @@ -182,11 +182,11 @@ def load_table(self, identifier: str | Identifier) -> Table:
try:
cursor.execute(METADATA_QUERY, (sf_identifier.table_name,))
# Extract the metadata path from the output
metadata = json.loads(cursor.fetchone()["METADATA"])["metadataLocation"]
metadata_loc = json.loads(cursor.fetchone()["METADATA"])["metadataLocation"]
except Exception as e:
raise NoSuchTableError(f"Table {sf_identifier.table_name} not found") from e

_fs_scheme = urlparse(metadata)
_fs_scheme = urlparse(metadata_loc)
_fs_props = {}

if _fs_scheme.scheme == "s3":
Expand All @@ -200,11 +200,16 @@ def load_table(self, identifier: str | Identifier) -> Table:
else:
warnings.warn(f"Unsupported filesystem scheme: {_fs_scheme.scheme}")

tbl = StaticTable.from_metadata(metadata, properties=_fs_props)
tbl._identifier = tuple(identifier.split(".")) if isinstance(identifier, str) else identifier
tbl.catalog = self

return tbl
io = self._load_file_io(properties=_fs_props, location=metadata_loc)
file = io.new_input(metadata_loc)
metadata = FromInputFile.table_metadata(file)
return Table(
self.identifier_to_tuple(identifier),
metadata,
metadata_loc,
io=self._load_file_io({**_fs_props, **metadata.properties}),
catalog=self,
)

def register_table(self, identifier: str | Identifier, metadata_location: str) -> Table:
query = "CREATE ICEBERG TABLE (%s) METADATA_FILE_PATH = (%s)"
Expand Down