Skip to content

Write Deletion Vectors #2822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rambleraptor wants to merge 6 commits into
base: main
Choose a base branch
from
+292 −1
Open

Write Deletion Vectors #2822

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9a4b91d
deletion vector write
rambleraptor Dec 8, 2025
4db1734
test fix
rambleraptor Dec 8, 2025
71dd925
lint fixes
rambleraptor Dec 8, 2025
3efd28e
test: Add Spark interop test for Puffin DV reader
glesperance Dec 11, 2025
228263c
PR comments
rambleraptor Dec 12, 2025
36bb37f
lint
rambleraptor Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test fix
  • Loading branch information
@rambleraptor
rambleraptor committed Dec 8, 2025
commit 4db1734cd4ee7d3c7fcfaa4e61e26cb8f0002c0c
12 changes: 7 additions & 5 deletions pyiceberg/table/puffin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,14 +219,16 @@ def finish(self) -> bytes:
for blob_payload in self._blob_payloads:
payload_buffer.write(blob_payload)

# Set offsets and lengths in metadata
current_offset = 4 # Start after file magic
updated_blobs_metadata: List[PuffinBlobMetadata] = []
current_offset = 4 # Start after file magic (4 bytes)
for i, blob_payload in enumerate(self._blob_payloads):
self._blobs[i].offset = current_offset
self._blobs[i].length = len(blob_payload)
original_metadata_dict = self._blobs[i].model_dump(by_alias=True, exclude_none=True)
original_metadata_dict["offset"] = current_offset
original_metadata_dict["length"] = len(blob_payload)
updated_blobs_metadata.append(PuffinBlobMetadata(**original_metadata_dict))
current_offset += len(blob_payload)

footer = Footer(blobs=self._blobs)
footer = Footer(blobs=updated_blobs_metadata)
footer_payload_bytes = footer.model_dump_json(by_alias=True, exclude_none=True).encode("utf-8")

# Final assembly
Expand Down
6 changes: 3 additions & 3 deletions tests/table/test_puffin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
import pytest
from pyroaring import BitMap

from pyiceberg.table.puffin import _deserialize_bitmap, PuffinFile, PuffinWriter
from pyiceberg.table.puffin import _deserialize_bitmap, PuffinFile, PuffinWriter, PROPERTY_REFERENCED_DATA_FILE


def _open_file(file: str) -> bytes:
Expand Down Expand Up @@ -94,11 +94,11 @@ def test_puffin_round_trip():
assert len(reader.footer.blobs) == 2

blob1_meta = reader.footer.blobs[0]
assert blob1_meta.properties[PuffinFile.PROPERTY_REFERENCED_DATA_FILE] == file1_path
assert blob1_meta.properties[PROPERTY_REFERENCED_DATA_FILE] == file1_path
assert blob1_meta.properties["cardinality"] == str(len(deletions1))

blob2_meta = reader.footer.blobs[1]
assert blob2_meta.properties[PuffinFile.PROPERTY_REFERENCED_DATA_FILE] == file2_path
assert blob2_meta.properties[PROPERTY_REFERENCED_DATA_FILE] == file2_path
assert blob2_meta.properties["cardinality"] == str(len(deletions2))

# Assert the content of deletion vectors
Expand Down