Skip to content

fix(rest): handle empty body in AWS SigV4 signing #2827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
plusplusjiajia wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(rest): handle empty body in AWS SigV4 signing #2827

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc9f0f9
fix(rest): handle empty body in AWS SigV4 signing
plusplusjiajia Dec 15, 2025
750b14b
fix format.
plusplusjiajia Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix format.
  • Loading branch information
@plusplusjiajia
plusplusjiajia committed Dec 15, 2025
commit 750b14b80af226881989a6651c9421ac6e0c6672
4 changes: 1 addition & 3 deletions pyiceberg/catalog/rest/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,9 +427,7 @@ def add_headers(self, request: PreparedRequest, **kwargs: Any) -> None: # pylin
# For empty bodies, explicitly set the content hash header to the SHA256 of an empty string
body = request.body
if body in (None, b"", ""):
request.headers["x-amz-content-sha256"] = (
"e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855"
)
request.headers["x-amz-content-sha256"] = "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855"

aws_request = AWSRequest(
method=request.method, url=url, params=params, data=request.body, headers=dict(request.headers)
Expand Down