Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add test description
  • Loading branch information
HonahX committed Jul 2, 2024
commit 3e3a1b495318a2c5251c304b8c200a2bf4d3b05b
11 changes: 8 additions & 3 deletions tests/catalog/test_sql.py
Original file line number Diff line number Diff line change
Expand Up @@ -1500,8 +1500,9 @@ def test_table_exists(catalog: SqlCatalog, table_schema_simple: Schema, table_id
],
)
@pytest.mark.parametrize("format_version", [1, 2])
def test_merge_manifests_file_integrity(catalog: SqlCatalog, arrow_table_with_null: pa.Table, format_version: int) -> None:
# temporary test for proof of correctness
def test_merge_manifests_local_file_system(catalog: SqlCatalog, arrow_table_with_null: pa.Table, format_version: int) -> None:
# To catch manifest file name collision bug during merge:
# https://github.com/apache/iceberg-python/pull/363#discussion_r1660691918
catalog.create_namespace_if_not_exists("default")
try:
catalog.drop_table("default.test_merge_manifest")
Expand All @@ -1510,7 +1511,11 @@ def test_merge_manifests_file_integrity(catalog: SqlCatalog, arrow_table_with_nu
tbl = catalog.create_table(
"default.test_merge_manifest",
arrow_table_with_null.schema,
properties={"commit.manifest.min-count-to-merge": "1", "format-version": format_version},
properties={
"commit.manifest-merge.enabled": "true",
"commit.manifest.min-count-to-merge": "2",
"format-version": format_version,
},
)

for _ in range(5):
Expand Down