Skip to content

Bin-pack Writes Operation into multiple parquet files, and parallelize writing WriteTasks #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fokko merged 15 commits into from
Mar 28, 2024
Merged

Bin-pack Writes Operation into multiple parquet files, and parallelize writing WriteTasks #444

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
5a7c8f9
bin pack write
kevinjqliu Feb 23, 2024
bae32e2
add write target file size config
kevinjqliu Feb 23, 2024
2730a8f
test
kevinjqliu Feb 23, 2024
ef64c92
add test for multiple data files
kevinjqliu Feb 23, 2024
9cb9649
parquet writer write once
kevinjqliu Feb 23, 2024
3f284b2
parallelize write tasks
kevinjqliu Feb 23, 2024
6462d06
refactor
kevinjqliu Feb 25, 2024
fd1efe0
chunk correctly using to_batches
kevinjqliu Feb 25, 2024
7ccfdb2
change variable names
kevinjqliu Feb 27, 2024
1ee3a55
get rid of assert
kevinjqliu Mar 6, 2024
f92de1a
configure PackingIterator
kevinjqliu Mar 6, 2024
0047fd8
add more tests
kevinjqliu Mar 6, 2024
c6cb8de
rewrite set_properties
kevinjqliu Mar 8, 2024
d80054d
set int property
kevinjqliu Mar 9, 2024
8cd7160
Merge branch 'main' into kevinjqliu/bin-pack-write
kevinjqliu Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
configure PackingIterator
  • Loading branch information
@kevinjqliu
kevinjqliu committed Mar 9, 2024
commit f92de1a1af2f71e7a2058acb7457b265ca14f75c
4 changes: 2 additions & 2 deletions pyiceberg/io/pyarrow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1777,9 +1777,9 @@ def bin_pack_arrow_table(tbl: pa.Table, target_file_size: int) -> Iterator[List[
bin_packed_record_batches = PackingIterator(
items=batches,
target_weight=target_file_size,
lookback=2,
lookback=len(batches), # ignore lookback
weight_func=lambda x: x.nbytes,
largest_bin_first=True,
largest_bin_first=False,
)
return bin_packed_record_batches

Expand Down