Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
adopt review feedback
  • Loading branch information
sungwy committed May 7, 2024
commit 6a39eda3ea0992b591757f857b57c117d0b36e0b
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ test-integration:
sleep 10
docker compose -f dev/docker-compose-integration.yml cp ./dev/provision.py spark-iceberg:/opt/spark/provision.py
docker compose -f dev/docker-compose-integration.yml exec -T spark-iceberg ipython ./provision.py
poetry run pytest tests/integration/test_writes/test_partitioned_writes.py -v -m integration ${PYTEST_ARGS}
poetry run pytest tests/ -v -m integration ${PYTEST_ARGS}

test-integration-rebuild:
docker compose -f dev/docker-compose-integration.yml kill
Expand Down
18 changes: 15 additions & 3 deletions pyiceberg/transforms.py
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,9 @@ def __eq__(self, other: Any) -> bool:
def supports_pyarrow_transform(self) -> bool:
return False

@abstractmethod
def pyarrow_transform(self, source: IcebergType) -> "Callable[[pa.Array], pa.Array]": ...


class BucketTransform(Transform[S, int]):
"""Base Transform class to transform a value into a bucket partition value.
Expand Down Expand Up @@ -297,6 +300,9 @@ def __repr__(self) -> str:
"""Return the string representation of the BucketTransform class."""
return f"BucketTransform(num_buckets={self._num_buckets})"

def pyarrow_transform(self, source: IcebergType) -> "Callable[[pa.Array], pa.Array]":
raise NotImplementedError()


class TimeResolution(IntEnum):
YEAR = 6
Expand Down Expand Up @@ -356,9 +362,6 @@ def dedup_name(self) -> str:
def preserves_order(self) -> bool:
return True

@abstractmethod
def pyarrow_transform(self, source: IcebergType) -> "Callable[[pa.Array], pa.Array]": ...

@property
def supports_pyarrow_transform(self) -> bool:
return True
Expand Down Expand Up @@ -810,6 +813,9 @@ def __repr__(self) -> str:
"""Return the string representation of the TruncateTransform class."""
return f"TruncateTransform(width={self._width})"

def pyarrow_transform(self, source: IcebergType) -> "Callable[[pa.Array], pa.Array]":
raise NotImplementedError()


@singledispatch
def _human_string(value: Any, _type: IcebergType) -> str:
Expand Down Expand Up @@ -892,6 +898,9 @@ def __repr__(self) -> str:
"""Return the string representation of the UnknownTransform class."""
return f"UnknownTransform(transform={repr(self._transform)})"

def pyarrow_transform(self, source: IcebergType) -> "Callable[[pa.Array], pa.Array]":
raise NotImplementedError()


class VoidTransform(Transform[S, None], Singleton):
"""A transform that always returns None."""
Expand Down Expand Up @@ -920,6 +929,9 @@ def __repr__(self) -> str:
"""Return the string representation of the VoidTransform class."""
return "VoidTransform()"

def pyarrow_transform(self, source: IcebergType) -> "Callable[[pa.Array], pa.Array]":
raise NotImplementedError()


def _truncate_number(
name: str, pred: BoundLiteralPredicate[L], transform: Callable[[Optional[L]], Optional[L]]
Expand Down