Skip to content

Glue endpoint config variable, continue #530 #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HonahX merged 7 commits into from
Jul 12, 2024
Merged

Glue endpoint config variable, continue #530 #920

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d77d6c9
adding test for glue endpoint override
sebpretzer Mar 18, 2024
19e970c
removing unnecessary code
sebpretzer Mar 18, 2024
9544494
Merge branch 'main' into honah_glue_endpoint_config
HonahX Jul 12, 2024
b9c6583
add integration test config
HonahX Jul 12, 2024
3aec52b
add doc
HonahX Jul 12, 2024
fb3f116
add missing mock_aws
HonahX Jul 12, 2024
b4feb33
make test happy
HonahX Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
make test happy
  • Loading branch information
@HonahX
HonahX committed Jul 12, 2024
commit b4feb335b99a70cd833b7518b4b584468fdb479b
7 changes: 4 additions & 3 deletions tests/catalog/test_glue.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -865,9 +865,10 @@ def test_register_table_with_given_location(


@mock_aws
def test_glue_endpoint_override(moto_endpoint_url: str, database_name: str) -> None:
def test_glue_endpoint_override(_bucket_initialize: None, moto_endpoint_url: str, database_name: str) -> None:
catalog_name = "glue"
test_endpoint = "https://test-endpoint"
test_catalog = GlueCatalog(
catalog_name, **{"s3.endpoint": moto_endpoint_url, "warehouse": f"s3://{BUCKET_NAME}", "glue.endpoint": moto_endpoint_url}
catalog_name, **{"s3.endpoint": moto_endpoint_url, "warehouse": f"s3://{BUCKET_NAME}", "glue.endpoint": test_endpoint}
)
assert test_catalog.glue.meta.endpoint_url == moto_endpoint_url
assert test_catalog.glue.meta.endpoint_url == test_endpoint