Skip to content

Allow empty names in mapped field of Name Mapping #927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fokko merged 5 commits into from
Jul 14, 2024
Merged

Allow empty names in mapped field of Name Mapping #927

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c9bfa27
Remove check_at_least_one field validator
spock-abadai Jul 13, 2024
15b05c7
Remove irrelevant test case
spock-abadai Jul 13, 2024
12c3591
Fixing pydantic model
spock-abadai Jul 14, 2024
f7ef81c
Added test case for empty names in name mapping
spock-abadai Jul 14, 2024
9bea754
Fixed formatting error
spock-abadai Jul 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixing pydantic model 
No longer requiring minimum length of names list to be 1.
  • Loading branch information
@spock-abadai
spock-abadai committed Jul 14, 2024
commit 12c35913b489d458d3d920fff33846a89b9a67c6
2 changes: 1 addition & 1 deletion pyiceberg/table/name_mapping.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@

class MappedField(IcebergBaseModel):
field_id: int = Field(alias="field-id")
names: List[str] = conlist(str, min_length=1)
names: List[str] = conlist(str)
fields: List[MappedField] = Field(default_factory=list)

@field_validator("fields", mode="before")
Expand Down