Skip to content

feat: partition compatibility #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Xuanwo merged 3 commits into from
Sep 8, 2024
Merged

feat: partition compatibility #612

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e90d121
Partition compatability
c-thiel Sep 8, 2024
c04370f
Partition compatability
c-thiel Sep 8, 2024
64303ea
Rename compatible_with -> is_compatible_with
c-thiel Sep 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Partition compatability
  • Loading branch information
@c-thiel
c-thiel committed Sep 8, 2024
commit c04370f2cfba7dc737994087107718b2e2bf562f
6 changes: 3 additions & 3 deletions crates/iceberg/src/spec/partition.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1593,7 +1593,7 @@ mod tests {

assert_eq!(1000, spec.fields[0].field_id);
assert_eq!(1001, spec.fields[1].field_id);
assert_eq!(spec.has_sequential_ids(), true);
assert!(spec.has_sequential_ids());
}

#[test]
Expand Down Expand Up @@ -1633,7 +1633,7 @@ mod tests {

assert_eq!(999, spec.fields[0].field_id);
assert_eq!(1000, spec.fields[1].field_id);
assert_eq!(spec.has_sequential_ids(), false);
assert!(!spec.has_sequential_ids());
}

#[test]
Expand Down Expand Up @@ -1673,6 +1673,6 @@ mod tests {

assert_eq!(1000, spec.fields[0].field_id);
assert_eq!(1002, spec.fields[1].field_id);
assert_eq!(spec.has_sequential_ids(), false);
assert!(!spec.has_sequential_ids());
}
}