Skip to content

Spark: Fix Alignment of Merge Commands with Mixed Case #4848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RussellSpitzer merged 6 commits into from
May 25, 2022
Merged

Spark: Fix Alignment of Merge Commands with Mixed Case #4848

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cc88935
Spark: Fix Alignment of Merge Commands with Mixed Case
RussellSpitzer May 23, 2022
045b76b
Reviewer Comments
RussellSpitzer May 24, 2022
64583bc
Fix block import
RussellSpitzer May 24, 2022
0dbff9d
More Style Errors
RussellSpitzer May 24, 2022
f5923a7
Fix Error Messages
RussellSpitzer May 25, 2022
cc93232
Formatting was bothering me
RussellSpitzer May 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Formatting was bothering me
  • Loading branch information
@RussellSpitzer
RussellSpitzer committed May 25, 2022
commit cc932326bc1f5f05ee2e10fda2c07ddf64f8dd8b
8 changes: 6 additions & 2 deletions spark/v3.2/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMerge.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1206,9 +1206,13 @@ public void testMergeMixedCaseAlignsUpdateAndInsertActions() {
ImmutableList.of(row(1, -2, "new_str_1"), row(2, -20, "new_str_2")),
sql("SELECT * FROM %s ORDER BY id", tableName));

assertEquals("Output should match", ImmutableList.of(row(1, -2, "new_str_1")),
assertEquals(
"Output should match",
ImmutableList.of(row(1, -2, "new_str_1")),
sql("SELECT * FROM %s WHERE id = 1 ORDER BY id", tableName));
assertEquals("Output should match", ImmutableList.of(row(2, -20, "new_str_2")),
assertEquals(
"Output should match",
ImmutableList.of(row(2, -20, "new_str_2")),
sql("SELECT * FROM %s WHERE b = 'new_str_2'ORDER BY id", tableName));
}

Expand Down