[GLUTEN-3962][VL] Respect parsed attribute name and remove column name validate logic #3963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Gluten Clickhouse CI |
Contributor
Author
|
Spark33 allow read parquet column with special characters but Spark32 does not.... details see apache/spark#35229 |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
Contributor
Author
|
@PHILO-HE @rui-mo @ulysses-you please help review, thank you! |
PHILO-HE
reviewed
Dec 8, 2023
Member
PHILO-HE
left a comment
PHILO-HE
left a comment
There was a problem hiding this comment.
Thanks for your work! Just few comments.
backends-velox/src/test/scala/io/glutenproject/execution/TestOperator.scala
Outdated
Show resolved
Hide resolved
|
Run Gluten Clickhouse CI |
1 similar comment
|
Run Gluten Clickhouse CI |
ulysses-you
reviewed
Dec 8, 2023
backends-velox/src/test/scala/io/glutenproject/execution/TestOperator.scala
Outdated
Show resolved
Hide resolved
gluten-core/src/main/scala/io/glutenproject/expression/ConverterUtils.scala
Outdated
Show resolved
Hide resolved
|
Run Gluten Clickhouse CI |
rui-mo
reviewed
Dec 11, 2023
gluten-core/src/main/scala/io/glutenproject/expression/ConverterUtils.scala
Outdated
Show resolved
Hide resolved
|
Run Gluten Clickhouse CI |
Contributor
Author
|
cc @waitinfuture please help rerun failed ci job, thank you! |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
Contributor
Author
|
@PHILO-HE @ulysses-you @rui-mo any more comments? |
Contributor
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Respect parsed attribute name from Spark,
sum(a)is a valid attr name in Spark.Remove column name validate logic safely since SparkTokenizer already added.
(Fixes: #3962)
How was this patch tested?
added UT.