Skip to content
This repository was archived by the owner on Apr 10, 2025. It is now read-only.

Conversation

oschaaf
Copy link
Member

@oschaaf oschaaf commented Feb 13, 2013

Display line numbers when an exception occurs during interpretation of a .pyconf file, for easier debugging

@oschaaf oschaaf closed this Feb 13, 2013
@oschaaf
Copy link
Member Author

oschaaf commented Feb 13, 2013

I tested some more, and noted that I'm not done with this yet, I need to add tracking of which key is defined at which line number to make sure I catch all I can.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line doesn't seem to do anything. If I remove it or change it to \n\n I still get the same incorrect line number (in my case 455 when I added an error on line 369) reported. (And the incorrect line numbers I'm seeing are too high, which is weird.)

@oschaaf oschaaf reopened this Feb 13, 2013
@oschaaf
Copy link
Member Author

oschaaf commented Feb 13, 2013

@jeffkaufman
This should display line numbers most of the time. The line numbers should also be correct now. I still need to modify move_configuration_to_locations and merge_location_config as well to accommodate for the moved paths. I think that if an error occurs during processing an inherited header configuration for example, the line number will display as 'unkown' now.I thought I'd make a pull out of what I have now for the sake of progress.

jeffkaufman added a commit that referenced this pull request Feb 13, 2013
…mbers

generate-config: display line numbers in errors
@jeffkaufman jeffkaufman merged commit a22f1f8 into oschaaf-generate-config Feb 13, 2013
@jeffkaufman jeffkaufman deleted the oschaaf-generate-config-linenumbers branch February 13, 2013 21:11
@jeffkaufman
Copy link
Contributor

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants