Skip to content

Conversation

@YC27
Copy link
Contributor

@YC27 YC27 commented Feb 21, 2025

as the title

@SteveYurongSu SteveYurongSu self-assigned this Feb 21, 2025
PROCESSOR_EXECUTOR.putIfAbsent(taskId, executorService);
PROCESSOR_TASK_MAP.putIfAbsent(taskId, collectorTask);

LOGGER.info("register collector processor task {}", taskId);

Check failure

Code scanning / CodeQL

Log Injection High

This log entry depends on a
user-provided value
.
PROCESSOR_TASK_MAP.remove(taskId).stop();
PROCESSOR_EXECUTOR.remove(taskId).shutdownNow();

LOGGER.info("deregister collector processor task {}", taskId);

Check failure

Code scanning / CodeQL

Log Injection High

This log entry depends on a
user-provided value
.
SINK_EXECUTOR.putIfAbsent(taskId, executorService);
SINK_TASK_MAP.putIfAbsent(taskId, collectorTask);

LOGGER.info("register collector sink task {}", taskId);

Check failure

Code scanning / CodeQL

Log Injection High

This log entry depends on a
user-provided value
.
SINK_TASK_MAP.remove(taskId).stop();
SINK_EXECUTOR.remove(taskId).shutdownNow();

LOGGER.info("deregister collector sink task {}", taskId);

Check failure

Code scanning / CodeQL

Log Injection High

This log entry depends on a
user-provided value
.
SOURCE_EXECUTOR.put(taskId, executorService);
SOURCE_TASK_MAP.putIfAbsent(taskId, collectorTask);

LOGGER.info("register collector source task {}", taskId);

Check failure

Code scanning / CodeQL

Log Injection High

This log entry depends on a
user-provided value
.
.ifPresent(
executor -> {
executor.submit(collectorTask);
LOGGER.info("register success {}", collectorTask.getTaskId());

Check failure

Code scanning / CodeQL

Log Injection High

This log entry depends on a
user-provided value
.
recordExecution(collectorTask, executor);
});
} else {
LOGGER.warn("task {} has existed", collectorTask.getTaskId());

Check failure

Code scanning / CodeQL

Log Injection High

This log entry depends on a
user-provided value
.
if (!validateIfAbsent(taskId)) {
eraseExecution(taskId);
} else {
LOGGER.warn("task {} has not existed", taskId);

Check failure

Code scanning / CodeQL

Log Injection High

This log entry depends on a
user-provided value
.

final boolean stopResult = CollectorAgent.task().stopCollectorTask(stopPipeRequest.getTaskId());
if (stopResult) {
LOGGER.info("Stop task: {} successful", stopPipeRequest.getTaskId());

Check failure

Code scanning / CodeQL

Log Injection High

This log entry depends on a
user-provided value
.
LOGGER.info("Stop task: {} successful", stopPipeRequest.getTaskId());
return Response.ok().entity("stop task: " + stopPipeRequest.getTaskId() + " success").build();
}
LOGGER.warn("Stop task: {} failed", stopPipeRequest.getTaskId());

Check failure

Code scanning / CodeQL

Log Injection High

This log entry depends on a
user-provided value
.
@SteveYurongSu SteveYurongSu merged commit a812c4c into apache:master Feb 21, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants