MINOR: Remove metrics attribute from StreamsGroup #20559
Conversation
github-actions
bot
added
triage
There was a problem hiding this comment.
Pull Request Overview
Removes the unused metrics dependency from StreamsGroup by dropping the metrics field and constructor parameter, and updating all visible instantiations accordingly.
- Removed GroupCoordinatorMetricsShard field and constructor argument from StreamsGroup.
- Updated all StreamsGroup constructions in tests and GroupMetadataManager to use the new signature.
- Cleaned up now-unused imports and test scaffolding (mocks and TopicPartition usage).
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| StreamsGroupTest.java | Updated all StreamsGroup instantiations to new constructor; removed related imports and mock setup. |
| StreamsGroup.java | Removed metrics field and constructor parameter plus null check. |
| GroupMetadataManager.java | Adjusted StreamsGroup instantiations to new constructor signature. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| public StreamsGroup( | ||
| LogContext logContext, | ||
| SnapshotRegistry snapshotRegistry, | ||
| String groupId, | ||
| GroupCoordinatorMetricsShard metrics | ||
| String groupId | ||
| ) { |
There was a problem hiding this comment.
The removal of the GroupCoordinatorMetricsShard constructor parameter is a breaking change to this public constructor. If StreamsGroup is intended for external (non-internal) use, consider a deprecation cycle or documenting the change in release notes; otherwise, mark the class or constructor clearly as internal to avoid unintended API breakage.
Copilot uses AI. Check for mistakes.
The
metricsattribute inStreamsGroupis not used anymore. Thispatch removes it.
Reviewers: Ken Huang [email protected], Lucas Brutschy
[email protected], Chia-Ping Tsai [email protected]