-
Notifications
You must be signed in to change notification settings - Fork 14.8k
KAFKA-19964: API Versions Response returns minimum metadata version for finalized level when no quorum exists #21122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mannoopj
wants to merge
6
commits into
apache:trunk
Choose a base branch
from
mannoopj:KAFKA-19964
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+33
−19
Open
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
6d53ead
Add optional FinalizedFeatures
mannoopj 3126d1c
Revert "Add optional FinalizedFeatures"
mannoopj 80de492
Have MetadataVersion be optional rather than FinalizedFeatures
mannoopj 08fcd72
remove FinalizedFeatures.EMPTY
mannoopj f072ffb
nit fixes
mannoopj 92e34e4
reverse removal of isControllerRegistrationSupported check
mannoopj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
nit fixes
- Loading branch information
commit f072ffb1724761b653ccac25fc0015a374f5964c
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1060,8 +1060,8 @@ class ControllerApis( | |
| // Nearly all RPCs should check MetadataVersion inside the QuorumController. However, this | ||
| // RPC is consulting a cache which lives outside the QC. So we check MetadataVersion here. | ||
| if (!apiVersionManager.features.metadataVersion().map(_.isControllerRegistrationSupported).orElse(false)) { | ||
| throw new UnsupportedVersionException("Direct-to-controller communication is not " + | ||
| "supported with the current MetadataVersion.") | ||
| throw new UnsupportedVersionException("There is no finalized MetadataVersion, so " + | ||
| "direct-to-controller communication is not supported.") | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please make a separate if/else if clause for if the metadata version is not finalized. We should not change this existing check. |
||
| } | ||
| // Unlike on the broker, DESCRIBE_CLUSTER on the controller requires a high level of | ||
| // permissions (ALTER on CLUSTER). | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better if we could return a more accurate error message in the case where
metadataVersion().isEmpty(). Returning a message like "There is no finalized MetadataVersion, so direct-to-controller communication is not supported" is more accurate in this case.