Skip to content

KAFKA-19331: Fix misleading log messages when follower's leader is not in metadata image #21123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devtrace404 wants to merge 4 commits into
base: trunk
Choose a base branch
from
Open

KAFKA-19331: Fix misleading log messages when follower's leader is not in metadata image #21123

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f2c8ced
KAFKA-19331: Fix misleading log messages when follower's leader is no…
geek-bit Dec 9, 2025
4bfb5c2
Minor refactoring
geek-bit Dec 9, 2025
1f6efc9
nit
geek-bit Dec 11, 2025
791a9c1
Remove UT
geek-bit Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove UT
  • Loading branch information
@geek-bit
geek-bit committed Dec 11, 2025
commit 791a9c17629839a6632a033c20f6d37d9dfe57fe
42 changes: 0 additions & 42 deletions core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4629,48 +4629,6 @@ class ReplicaManagerTest {
}
}

@ParameterizedTest
@ValueSource(booleans = Array(true, false))
def testDeltaFollowerWhenLeaderNotInClusterImage(enableRemoteStorage: Boolean): Unit = {
val localId = 1
val leaderId = 99
val topicPartition = new TopicPartition("foo", 0)
val replicaManager = setupReplicaManagerWithMockedPurgatories(new MockTimer(time), localId, enableRemoteStorage = enableRemoteStorage)

try {
// Create a delta where localId is follower and leaderId (99) is the leader
// The leader ID 99 does NOT exist in ClusterImageTest.IMAGE1
val delta = new TopicsDelta(TopicsImage.EMPTY)
delta.replay(new TopicRecord().setName("foo").setTopicId(FOO_UUID))
delta.replay(new PartitionRecord()
.setPartitionId(0)
.setTopicId(FOO_UUID)
.setReplicas(util.Arrays.asList(localId, leaderId))
.setIsr(util.Arrays.asList(localId, leaderId))
.setLeader(leaderId) // Leader is broker 99
.setLeaderEpoch(0)
.setPartitionEpoch(0))

// Use the standard cluster image which does NOT contain broker 99
val metadataImage = imageFromTopics(delta.apply())

replicaManager.applyDelta(delta, metadataImage)

// Verify the partition was created and is a follower
val HostedPartition.Online(followerPartition) = replicaManager.getPartition(topicPartition)
assertFalse(followerPartition.isLeader)
assertEquals(0, followerPartition.getLeaderEpoch)
assertEquals(Some(leaderId), followerPartition.leaderReplicaIdOpt)

// Verify no fetcher was started since the leader (99) is not in the cluster image
val fetcher = replicaManager.replicaFetcherManager.getFetcher(topicPartition)
assertEquals(None, fetcher, "No fetcher should be started when leader is not in cluster image")

} finally {
replicaManager.shutdown(checkpointHW = false)
}
}

@ParameterizedTest
@ValueSource(booleans = Array(true, false))
def testDeltaFollowerToNotReplica(enableRemoteStorage: Boolean): Unit = {
Expand Down