add more checks for query sql

kyuubi-common/src/main/scala/org/apache/kyuubi/service/authentication/JdbcAuthenticationProviderImpl.scala

@@ -63,14 +63,7 @@ class JdbcAuthenticationProviderImpl(conf: KyuubiConf) extends PasswdAuthenticat
 
     checkConfigs
 
-    // Load Driver Class
-    try {
-      Class.forName(dbDriver.get)
-    } catch {
-      case e: ClassNotFoundException =>
-        error(s"Driver class not found: $dbDriver")
-        throw e;
-    }
+    loadJdbcDriverClass
 
     var connection: Connection = null
     var queryStatement: PreparedStatement = null
@@ -127,9 +120,27 @@ class JdbcAuthenticationProviderImpl(conf: KyuubiConf) extends PasswdAuthenticat
     if (querySql.isEmpty) {
       throw new IllegalArgumentException("Query SQL is not configured")
     }
-    if (!querySql.get.trim.toLowerCase.startsWith("select")) { // only allow select query sql
+    val querySqlInLowerCase = querySql.get.trim.toLowerCase
+    if (!querySqlInLowerCase.startsWith("select")) { // allow select query sql only
       throw new IllegalArgumentException("Query SQL must start with \"SELECT\"");
     }
+    if (!querySqlInLowerCase.contains("where")) {
+      warn("Query SQL does not contains \"WHERE\" keyword");
+    }
+    if (!querySqlInLowerCase.contains("${username}")) {
+      warn("Query SQL does not contains \"${username}\" placeholder");
+    }
+  }
+
+  private def loadJdbcDriverClass: Unit = {
+    // Load Driver Class
+    try {
+      Class.forName(dbDriver.get)
+    } catch {
+      case e: ClassNotFoundException =>
+        error(s"JDBC Driver class not found: $dbDriver")
+        throw e;
+    }
   }
 
   /**
@@ -164,9 +175,9 @@ class JdbcAuthenticationProviderImpl(conf: KyuubiConf) extends PasswdAuthenticat
    * @return
    */
   private def getAndPrepareStatement(
-                                      connection: Connection,
-                                      user: String,
-                                      password: String): PreparedStatement = {
+      connection: Connection,
+      user: String,
+      password: String): PreparedStatement = {
     // Replace placeholders by "?" and prepare the statement
     val stmt = connection.prepareStatement(getPreparedSql(querySql.get))
 

kyuubi-common/src/test/scala/org/apache/kyuubi/service/authentication/JdbcAuthenticationProviderImplSuite.scala

@@ -81,19 +81,6 @@ class JdbcAuthenticationProviderImplSuite extends KyuubiFunSuite {
     }
   }
 
-  def genJdbcAuthConfigs: KyuubiConf = {
-    conf = new KyuubiConf()
-    conf.set(AUTHENTICATION_JDBC_DRIVER, "org.apache.derby.jdbc.AutoloadedDriver")
-    conf.set(AUTHENTICATION_JDBC_URL, jdbcUrl)
-    conf.set(AUTHENTICATION_JDBC_USERNAME, dbUser)
-    conf.set(AUTHENTICATION_JDBC_PASSWORD, dbPasswd)
-    conf.set(
-      AUTHENTICATION_JDBC_QUERY,
-      "SELECT 1 FROM user_auth " +
-        " WHERE username=${username} and passwd=${password}")
-    conf
-  }
-
   test("authenticate tests") {
     var providerImpl = new JdbcAuthenticationProviderImpl(conf)
 
@@ -133,8 +120,10 @@ class JdbcAuthenticationProviderImplSuite extends KyuubiFunSuite {
     val e8 = intercept[IllegalArgumentException](providerImpl.authenticate(authUser, authPasswd))
     assert(e8.getMessage.contains("Query SQL is not configured"))
 
-    conf.set(AUTHENTICATION_JDBC_QUERY, "INSERT INTO user_auth (username, password) " +
-      " VALUES ('demouser','demopassword'); ")
+    conf.set(
+      AUTHENTICATION_JDBC_QUERY,
+      "INSERT INTO user_auth (username, password) " +
+        " VALUES ('demouser','demopassword'); ")
     providerImpl = new JdbcAuthenticationProviderImpl(conf)
     val e9 = intercept[IllegalArgumentException](providerImpl.authenticate(authUser, authPasswd))
     assert(e9.getMessage.contains("Query SQL must start with \"SELECT\""))
@@ -144,4 +133,17 @@ class JdbcAuthenticationProviderImplSuite extends KyuubiFunSuite {
     val e10 = intercept[IllegalArgumentException](providerImpl.authenticate(authUser, authPasswd))
     assert(e10.getMessage.contains("JDBC url is not configured"))
   }
+
+  private def genJdbcAuthConfigs: KyuubiConf = {
+    conf = new KyuubiConf()
+    conf.set(AUTHENTICATION_JDBC_DRIVER, "org.apache.derby.jdbc.AutoloadedDriver")
+    conf.set(AUTHENTICATION_JDBC_URL, jdbcUrl)
+    conf.set(AUTHENTICATION_JDBC_USERNAME, dbUser)
+    conf.set(AUTHENTICATION_JDBC_PASSWORD, dbPasswd)
+    conf.set(
+      AUTHENTICATION_JDBC_QUERY,
+      "SELECT 1 FROM user_auth " +
+        " WHERE username=${username} and passwd=${password}")
+    conf
+  }
 }