Skip to content

Conversation

@kwin
Copy link
Member

@kwin kwin commented Nov 29, 2022

This requires a dedicated follow-up commit according to https://lists.apache.org/thread/14n13z4sh3twy5qgp5f487f1z0s5pc4s

@slawekjaranowski
Copy link
Member

Please fix checkstyle configuration like in: apache/maven-dependency-plugin#266
and check site reports

@kwin kwin force-pushed the feature/parent-38 branch from 88e43da to 8764ce6 Compare November 30, 2022 09:26
@kwin
Copy link
Member Author

kwin commented Nov 30, 2022

Please fix checkstyle configuration like in: apache/maven-dependency-plugin#266 and check site reports

Done now.

@elharo
Copy link
Contributor

elharo commented Dec 3, 2022

Why does upgrading the parent POM reformat pretty much every file? That seems like a very different thing.

@kwin
Copy link
Member Author

kwin commented Dec 3, 2022

Why does upgrading the parent POM reformat pretty much every file? That seems like a very different thing.

That is because the code format conventions have changed. There was a mailing list discussion around that.

@slawekjaranowski
Copy link
Member

@kwin look for duplicate License headers

can help:

git grep -c "Licensed to the Apache Software Foundation" | grep -v ":1"

@kwin
Copy link
Member Author

kwin commented Dec 3, 2022

@kwin look for duplicate License headers

can help:

git grep -c "Licensed to the Apache Software Foundation" | grep -v ":1"

Thanks for the hint. Is there a configuration in spotless to remove those duplicates or do you have a script for that available as well? Seems that almost all files have duplicate license headers after the automated formatting…

@slawekjaranowski
Copy link
Member

@kwin look for duplicate License headers
can help:

git grep -c "Licensed to the Apache Software Foundation" | grep -v ":1"

Thanks for the hint. Is there a configuration in spotless to remove those duplicates or do you have a script for that available as well? Seems that almost all files have duplicate license headers after the automated formatting…

In IDE I copy old header and use options replace all.

@kwin kwin force-pushed the feature/parent-38 branch from 8764ce6 to 05d8867 Compare December 5, 2022 10:22
@gnodet gnodet changed the title [MPLUGIN-447] Update to Maven Parent POM 38 [MPLUGIN-447] Update to Maven Parent POM 39 Feb 9, 2023
@gnodet gnodet force-pushed the feature/parent-38 branch 3 times, most recently from ef903ee to 199ecb1 Compare February 10, 2023 16:17
@gnodet gnodet merged commit 21f9d21 into master Feb 12, 2023
@gnodet gnodet deleted the feature/parent-38 branch February 14, 2023 09:45
@jira-importer
Copy link

Resolve #750

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants