Skip to content

Bug: GH-1703 Gaps in G segments resets result #1706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cstamas merged 4 commits into from
Dec 11, 2025
Merged

Bug: GH-1703 Gaps in G segments resets result #1706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
438289b
Bug: GH-1703
cstamas Dec 10, 2025
954a34d
Reformat
cstamas Dec 10, 2025
7e9bf1e
Add more tests
cstamas Dec 10, 2025
5a810f7
Fix comments
cstamas Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...solver-impl/src/main/java/org/eclipse/aether/internal/impl/filter/ruletree/GroupTree.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ public boolean acceptedGroupId(String groupId) {
}
if (currentNode.isStop() && groupElements.equals(current)) {
accepted = currentNode.isAllow();
} else if (!currentNode.isStop()) {
} else if (!currentNode.isStop() && currentNode.isAllow() != null) {
accepted = currentNode.isAllow();
}
}
Expand Down
33 changes: 33 additions & 0 deletions ...er-impl/src/test/java/org/eclipse/aether/internal/impl/filter/ruletree/GroupTreeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,4 +169,37 @@ void implicitAndExplicitDefaultIsSame() {

assertEquals(implicitResults, explicitResults);
}

@Test
void gh1703One() {
GroupTree groupTree;

// REPRODUCER as given
groupTree = new GroupTree("root");
// this is redundant, as 'org.apache' IMPLIES 'org.apache.maven.plugins'
groupTree.loadNodes(Stream.of("# comment", "", "org.apache", "org.apache.maven.plugins"));

assertTrue(groupTree.acceptedGroupId("org.apache")); // this is given
assertTrue(groupTree.acceptedGroupId("org.apache.maven")); // implied by first
assertTrue(groupTree.acceptedGroupId("org.apache.maven.plugins")); // implied by first (line is redundant)
assertTrue(groupTree.acceptedGroupId("org.apache.maven.plugins.foo")); // implied by first

// FIXED
groupTree = new GroupTree("root");
groupTree.loadNodes(Stream.of("# comment", "", "=org.apache", "org.apache.maven.plugins"));

assertTrue(groupTree.acceptedGroupId("org.apache")); // this is given (=)
assertFalse(groupTree.acceptedGroupId("org.apache.maven")); // not allowed
assertTrue(groupTree.acceptedGroupId("org.apache.maven.plugins")); // this is given (and below)
assertTrue(groupTree.acceptedGroupId("org.apache.maven.plugins.foo")); // implied by above

// MIXED
groupTree = new GroupTree("root");
groupTree.loadNodes(Stream.of("# comment", "", "org.apache", "!=org.apache.maven.plugins"));

assertTrue(groupTree.acceptedGroupId("org.apache")); // this is given
assertTrue(groupTree.acceptedGroupId("org.apache.maven")); // implied by first
assertFalse(groupTree.acceptedGroupId("org.apache.maven.plugins")); // this is given (!=)
assertTrue(groupTree.acceptedGroupId("org.apache.maven.plugins.foo")); // implied by first
}
}