Skip to content

[1.9.x] Bug: GH-1703 Locally cached artifacts defy RRF #1708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cstamas merged 2 commits into from
Dec 11, 2025
Merged

[1.9.x] Bug: GH-1703 Locally cached artifacts defy RRF #1708

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87690f5
Bug: GH-1703 Locally cached artifacts defy RRF
cstamas Dec 10, 2025
2beb771
Add UT
cstamas Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add UT
  • Loading branch information
@cstamas
cstamas committed Dec 11, 2025
commit 2beb7715a0a8567d30beb8da21c3bf5f24d18ef0
115 changes: 114 additions & 1 deletion ...lver-impl/src/test/java/org/eclipse/aether/internal/impl/DefaultArtifactResolverTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
import org.eclipse.aether.artifact.Artifact;
import org.eclipse.aether.artifact.ArtifactProperties;
import org.eclipse.aether.artifact.DefaultArtifact;
import org.eclipse.aether.impl.RemoteRepositoryFilterManager;
import org.eclipse.aether.impl.UpdateCheckManager;
import org.eclipse.aether.impl.VersionResolver;
import org.eclipse.aether.internal.impl.filter.DefaultRemoteRepositoryFilterManager;
Expand Down Expand Up @@ -63,6 +64,7 @@
import org.eclipse.aether.resolution.VersionResult;
import org.eclipse.aether.spi.connector.ArtifactDownload;
import org.eclipse.aether.spi.connector.MetadataDownload;
import org.eclipse.aether.spi.connector.filter.RemoteRepositoryFilter;
import org.eclipse.aether.spi.connector.filter.RemoteRepositoryFilterSource;
import org.eclipse.aether.transfer.ArtifactNotFoundException;
import org.eclipse.aether.transfer.ArtifactTransferException;
Expand Down Expand Up @@ -96,7 +98,7 @@ public class DefaultArtifactResolverTest {

private HashMap<String, RemoteRepositoryFilterSource> remoteRepositoryFilterSources;

private DefaultRemoteRepositoryFilterManager remoteRepositoryFilterManager;
private RemoteRepositoryFilterManager remoteRepositoryFilterManager;

@Before
public void setup() {
Expand Down Expand Up @@ -886,4 +888,115 @@ public VersionResult resolveVersion(RepositorySystemSession session, VersionRequ
resolved = resolved.setFile(null);
assertEquals(artifact, resolved);
}

@Test
public void testCachedButFilteredOut() {
remoteRepositoryFilterManager = new RemoteRepositoryFilterManager() {
@Override
public RemoteRepositoryFilter getRemoteRepositoryFilter(RepositorySystemSession session) {
return new RemoteRepositoryFilter() {
@Override
public Result acceptArtifact(RemoteRepository remoteRepository, Artifact artifact) {
return new Result() {
@Override
public boolean isAccepted() {
return false;
}

@Override
public String reasoning() {
return "REFUSED";
}
};
}

@Override
public Result acceptMetadata(RemoteRepository remoteRepository, Metadata metadata) {
return new Result() {
@Override
public boolean isAccepted() {
return true;
}

@Override
public String reasoning() {
return "OK";
}
};
}
};
}
};
session.setLocalRepositoryManager(new LocalRepositoryManager() {
public LocalRepository getRepository() {
return null;
}

public String getPathForRemoteMetadata(Metadata metadata, RemoteRepository repository, String context) {
return null;
}

public String getPathForRemoteArtifact(Artifact artifact, RemoteRepository repository, String context) {
return null;
}

public String getPathForLocalMetadata(Metadata metadata) {
return null;
}

public String getPathForLocalArtifact(Artifact artifact) {
return null;
}

public LocalArtifactResult find(RepositorySystemSession session, LocalArtifactRequest request) {
LocalArtifactResult result = new LocalArtifactResult(request);
result.setAvailable(false);
try {
result.setFile(TestFileUtils.createTempFile(""));
} catch (IOException e) {
e.printStackTrace();
}
return result;
}

public void add(RepositorySystemSession session, LocalArtifactRegistration request) {}

public LocalMetadataResult find(RepositorySystemSession session, LocalMetadataRequest request) {
LocalMetadataResult result = new LocalMetadataResult(request);
try {
result.setFile(TestFileUtils.createTempFile(""));
} catch (IOException e) {
e.printStackTrace();
}
return result;
}

public void add(RepositorySystemSession session, LocalMetadataRegistration request) {}
});

// rebuild resolver with our filter
resolver = new DefaultArtifactResolver();
resolver.setFileProcessor(new TestFileProcessor());
resolver.setRepositoryEventDispatcher(new StubRepositoryEventDispatcher());
resolver.setVersionResolver(new StubVersionResolver());
resolver.setUpdateCheckManager(new StaticUpdateCheckManager(false));
resolver.setRepositoryConnectorProvider(repositoryConnectorProvider);
resolver.setRemoteRepositoryManager(new StubRemoteRepositoryManager());
resolver.setSyncContextFactory(new StubSyncContextFactory());
resolver.setOfflineController(new DefaultOfflineController());
resolver.setArtifactResolverPostProcessors(Collections.emptyMap());
resolver.setRemoteRepositoryFilterManager(remoteRepositoryFilterManager);

ArtifactRequest request = new ArtifactRequest(artifact, null, "");
request.addRepository(new RemoteRepository.Builder("id", "default", "file:///").build());

// resolver should throw
try {
resolver.resolveArtifact(session, request);
fail("Should throw ArtifactResolutionException");
} catch (ArtifactResolutionException ex) {
// message should contain present=true, available=false, filter message
assertTrue(ex.getMessage().contains("gid:aid:ext:ver (present, but unavailable): REFUSED"));
}
}
}