GH-709: Handle keep-alive channel messages sent by an old OpenSSH server #710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SH server OpenSSH < 5.1p1 (from 2008!) does not handle a success reply and then disconnects after a few keepalives. It really needs a failure reply. Since 5.1p1, OpenSSH can handle both failure and success replies to its keepalive channel messages. Always return a failure reply if the request is "[email protected]".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenSSH < 5.1p1 (from 2008!) does not handle a success reply and then disconnects after a few keepalives. It really needs a failure reply. Since 5.1p1, OpenSSH can handle both failure and success replies to its keepalive channel messages.
Always return a failure reply if the request is "[email protected]".
Fixes #709.