GH-727: supply default port for proxyJump if no HostConfigEntry #730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If SshClient creates an empty HostConfigEntry, supply the default port if the given port is <= 0. I'd have liked to do that once and for all in HostConfigEntry.getPort(), but HostConfigEntry.append(Appendable a) relies on getPort() returning a value <= 0 if not set. If there _is_ a HostConfigEntry for the proxyJump, then HostConfigEntryResolver.resolveEffectiveHost() would already supply the default port. (That bit was fixed in version 2.10.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If SshClient creates an empty HostConfigEntry, supply the default port if the given port is <= 0.
I'd have liked to do that once and for all in HostConfigEntry.getPort(), but HostConfigEntry.append(Appendable a) relies on getPort() returning a value <= 0 if not set.
If there is a HostConfigEntry for the proxyJump, then HostConfigEntryResolver.resolveEffectiveHost() would already supply the default port. (That bit was fixed in version 2.10.)
Fixes #727.