Trigger ClientChannelEvent.Timeout and ClientSessionEvent.TIMEOUT independently to host's program cycle times #790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some hosts, on which waiting for the `futureLock.wait(remWait)` is faster than 1 millisecond, `remWait` gets reduced by 123 milliseconds although not even one passed. This causes a `ClientChannelEvent.Timeout` after a much smaller time passed than the configured timeout. As each host has different cycle times, this happens an unknown amount of times. With these changes, the `remWait` is calculated based on the milliseconds passed instead of transformed nanoseconds.
With the removal of the TimeUnit conversion from nanoseconds to milliseconds, import becomes obsolete.
On some hosts, on which waiting for the `futureLock.wait(remWait)` is faster than 1 millisecond, `remWait` gets reduced by 123 milliseconds although not even one passed. This causes a `ClientSessionEvent.TIMEOUT` after a much smaller time passed than the configured timeout. As each host has different cycle times, this happens an unknown amount of times. With these changes, the `remWait` is calculated based on the milliseconds passed instead of transformed nanoseconds.
fersaru
changed the title
remWait with passed milliseconds
Member
|
Thank you for this fix. The old code looks like someone put in some placeholder code and forgot to clean up later. |
fersaru
deleted the
fix/abstractclientchannel-remove-123-subtraction-from-remwait
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some hosts, on which waiting for the
futureLock.wait(remWait)is faster than 1 millisecond,remWaitgets reduced by 123 milliseconds although not even one passed.As each host has different cycle times, this happens an unknown amount of times.
This causes a
ClientChannelEvent.Timeoutafter a much smaller time passed than the configured timeout.With these changes, the
remWaitis calculated based on the milliseconds passed instead of transformed nanoseconds.The same code is found in
ClientSessionImpl@waitFor. This is also addressed.