ci: Enable newt test on Mac #3332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjanc
force-pushed
the
ci_mac
branch
2 times, most recently
from
57a94cf to
2ec1f0d
Compare
We properly support 64bit in native target now so those can be re-enabled.
kasjer
approved these changes
Oct 30, 2024
Enabling -Wsingle-bit-bitfield-constant-conversion compains.
repos/apache-mynewt-core/encoding/json/src/json_encode.c:187:27: error:
implicit truncation from 'int' to a one-bit wide bit-field changes
value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion]
562
encoder->je_wr_commas = 1;
563
^ ~
564
repos/apache-mynewt-core/encoding/json/src/json_encode.c:199:27: error:
implicit truncation from 'int' to a one-bit wide bit-field changes
value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion]
565
encoder->je_wr_commas = 1;
566
^ ~
567
repos/apache-mynewt-core/encoding/json/src/json_encode.c:233:27: error:
implicit truncation from 'int' to a one-bit wide bit-field changes
value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion]
568
encoder->je_wr_commas = 1;
569
^ ~
570
repos/apache-mynewt-core/encoding/json/src/json_encode.c:244:27: error:
implicit truncation from 'int' to a one-bit wide bit-field changes
value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion]
571
encoder->je_wr_commas = 1;
572
^ ~
Removed unused variable
repos/apache-mynewt-core/util/cbmem/selftest/src/testcases/
cbmem_test_case_3.c:29:9: error: variable 'i' set but not
used [-Werror,-Wunused-but-set-variable]
4941
int i;
4942
^
4943
1 error generated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We properly support 64bit in native target now so those can be re-enabled.