ORC-386 Add spark benchmarks. #290
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I also refactored all of the old benchmarks to reduce the common code. I also split it into three modules so that I could separate the common code, the code that depends on hive, and the code that depends on spark. Avoiding building an uber jar that has both hive and spark made life much easier.
Contributor
Author
|
@dongjoon-hyun if you have feedback on these benchmarks, that would be great. |
dongjoon-hyun
approved these changes
Jul 13, 2018
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM.
For #21582, I've got the following result from DecimalBench.
# Run complete. Total time: 00:05:40
Benchmark (version) Mode Cnt Score Error Units
DecimalBench.read ORIGINAL avgt 5 10375991.566 ± 99751.161 us/op
DecimalBench.read USE_DECIMAL64 avgt 5 7368917.561 ± 39257.332 us/op
DecimalBench.write ORIGINAL avgt 5 211008.673 ± 30220.403 us/op
DecimalBench.write USE_DECIMAL64 avgt 5 33881.693 ± 216.601 us/op
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also refactored all of the old benchmarks to reduce the common code. I also split it into three modules so that I could
separate the common code, the code that depends on hive, and the code that depends on spark. Avoiding building an uber
jar that has both hive and spark made life much easier.